Re: [PATCH] Let __attribute__((format(…))) accept OFStrings

Aaron Ballman aaron at aaronballman.com
Sun Nov 24 14:33:34 PST 2013


What is an OFString? How does it relate to an NSString, since this
code is in an isNSStringType helper method?

This patch is missing test cases for places this code touches.

~Aaron

On Sat, Nov 23, 2013 at 5:22 AM, Jonathan Schleifer <js at webkeks.org> wrote:
> The following patch changes the behavior of __attribute__((format(__NSString__, …))) to also allow OFStrings as used in ObjFW. I thought about adding __OFString__ instead, but thought this would be unnecessary overhead. If people disagree, I'm more than happy to add __OFString__ instead.
>
> Could you guys kindly review this patch and commit it if you deem it acceptable? If so, it would also nice if it could be committed to 3.4 as well.
>
> PS: Please CC me, I'm not on the list!
>
> --
> Jonathan
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>




More information about the cfe-commits mailing list