[PATCH] Fixing some ObjC attributes

Aaron Ballman aaron at aaronballman.com
Fri Nov 22 13:19:16 PST 2013


In my quest for consolidated attribute subject diagnostics, I ran into
these two cases where we were handling ObjC attributes outside of the
norm. Specifically:

objc_arc_weak_reference_unavailable had a Subjects that specified it
required an ObjcInterface, but no subject check in SemaDeclAttr.cpp
and no test case. This patch adds the semantics test and testcase.

objc_requires_property_definitions had a Subjects that specified it
required an ObjCInterface, but the diagnostic issued from
SemaDeclAttr.cpp was a custom one instead of the common one. This
patch changes the diagnostic and corrects an existing testcase.

Thanks!

~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ObjCAttr.patch
Type: application/octet-stream
Size: 3178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131122/21c36f10/attachment.obj>


More information about the cfe-commits mailing list