r194296 - Use rauw for all discardable aliases, not just linkonce_odr.

Joerg Sonnenberger joerg at britannica.bec.de
Fri Nov 22 08:37:33 PST 2013


On Fri, Nov 22, 2013 at 08:23:09AM -0500, Rafael EspĂ­ndola wrote:
> > How does the attached patch look?
> 
> Close, but please:
> 
> * Disallow only the "available_externally always_inline" combination.
> Your patch would disable it for all always_inline.
> * Add a comment to the file saying why we don't want to rauw if the
> target is is available_externally always_inline and maybe a FIXME
> about the existence of this combination being a bit odd.
> * clang-format the test :-)
> * merge the test into test/CodeGenCXX/ctor-dtor-alias.cpp

Updated.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-r194296.diff
Type: text/x-diff
Size: 2113 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131122/b05c2895/attachment.diff>


More information about the cfe-commits mailing list