[PATCH] Refactor duplicate functions

[Tim Northover]

  Hi Bernie,

  Thanks very much for taking a stab at this. I'm quite happy with the "arm" namespace myself, but have a reservation about Darwin:


================
Comment at: lib/Driver/ToolChain.cpp:167-169
@@ -166,5 @@
-                                   const llvm::Triple &Triple) {
-  // For Darwin targets, the -arch option (which is translated to a
-  // corresponding -march option) should determine the architecture
-  // (and the Mach-O slice) regardless of any -mcpu options.
-  if (!Triple.isOSDarwin()) {
----------------
It's a little difficult to tell because the patch no longer applies cleanly to trunk, but I suspect this comment has misled you. Darwin *does* take note of -mcpu, and I suspect this patch might disable that.


http://llvm-reviews.chandlerc.com/D2243

ARCANIST PROJECT
  clang