[LLVMdev] [PATCH] Prevent clang from throwing the diagnostics twice.

[Umesh Kalappa]

Chad and Aaron,

Thank you for the comments,Let me see how feasible to refactor the code so
that getOptimizationLevel() is called once .

Else we need to get cached  and reuse the same .

Thanks
~Umesh


On Sat, Nov 16, 2013 at 1:38 AM, Chad Rosier <mcrosier at codeaurora.org>wrote:

> > As Chad pointed, it's likely that this requires a non-trivial
> > refactoring. I don't have particularly bright ideas on solving it, but
> > I'm uncomfortable adding the flag at the arg level because it kind of
> > encourages lazy design when handling args. Perhaps looking into ways
> > the code could be refactored so that getOptimizationLevel() is only
> > called once (and perhaps the results get cached somewhere) would be a
> > good approach.
>
> I completely agree with you, Aaron.
>
>  Chad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131122/a9ab8fb0/attachment.html>