[PATCH] Added LanguageStandard::LS_JavaScript to gate all JS-specific parsing.

[Daniel Jasper]

On Thu, Nov 21, 2013 at 5:23 PM, Nico Weber <thakis at chromium.org> wrote:

> On Fri, Nov 22, 2013 at 4:05 AM, Daniel Jasper <djasper at google.com> wrote:
>
>> I think JS and C++ will almost always be in different sub-directories. So
>> different .clang-format files are the way to go..
>>
>
> For what it's worth, chromium has at least one directory that has both .cc
> and .js files. And I think it'd be nicer if a single top-level
> .clang-format was enough, instead of having to put one into every directory
> containing .js files.
>

I fully agree. But I think this will need an even more intricate approach
as still the style won't be perfectly identical in almost all cases. So
maybe the .clang-format file needs an entry per language then?


>
>>
>> On Thu, Nov 21, 2013 at 10:45 AM, Manuel Klimek <klimek at google.com>wrote:
>>
>>> On Thu, Nov 21, 2013 at 7:38 PM, Daniel Jasper <djasper at google.com>wrote:
>>>
>>>>
>>>>   After thinking some more, I guess my main reason is that I strongly
>>>> doubt
>>>>   that we'll ever have a JavaScript style and a C++ style that are
>>>> identical
>>>>   in all aspects other than the LanguageStandard.. So, the detection
>>>> based on
>>>>   the file extension inside clang-format will likely be redundant..
>>>>
>>>
>>> I think this would be useful for mixed open source projects (or
>>> companies without an existing style guide).
>>>  One interesting point is that our configuration is very "repo" centric,
>>> and there are enough mixed repos out there - how would we want to support
>>> this without major setup effort required for every engineer contributing to
>>> a project...
>>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131121/46c0fef3/attachment.html>