[PATCH] CMake: Some changes to package version naming:
Hans Wennborg
hans at chromium.org
Thu Nov 21 14:50:56 PST 2013
================
Comment at: CMakeLists.txt:16
@@ -15,2 +15,3 @@
-set(PACKAGE_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}svn")
+if (NOT PACKAGE_VERSION)
+ set(PACKAGE_VERSION "${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}svn")
----------------
Reid Kleckner wrote:
> If you don't cache this, I believe subsequent reconfigures will overwrite it. I don't think we can cache the PACKAGE_VERSION directly, I think Alp had to change that recently.
>
> Maybe we could have a PACKAGE_SUFFIX value defaulting to "svn" and cache that, since it doesn't change as the version updates? IMO this is fine as is, since building RCs happens rarely.
OK, I'll go with the current patch for now, and we can think about splitting off PACKAGE_SUFFIX later.
http://llvm-reviews.chandlerc.com/D2245
More information about the cfe-commits
mailing list