[PATCH][OpenCL] Fixing the crash in clang due to .hi and .odd accesses in vectors of odd size

[Tom Stellard]

On Thu, Nov 21, 2013 at 11:29:41AM +0200, Pekka J??skel?inen wrote:
> Hi,
> 
> On 11/20/2013 05:11 PM, Anastasia Stulova wrote:
> > +typedef unsigned char __attribute__((ext_vector_type(3))) uchar3;
> > +
> > +kernel void test_odd_vector1 (uchar3 lhs_lvalue)
> > +{
> > +	lhs_lvalue.odd = 1;
> > +}
> > +
> > +kernel void test_odd_vector2 (uchar3 lhs_lvalue)
> > +{
> > +	lhs_lvalue.hi = 2;
> > +}
> 
> Should these also test that the contents end up being correct,
> just in case?
> 
> Nitpick: the coding style of the test case functions
> might not match the LLVM coding style.
> 
> Otherwise, LGTM.
> 

I think we should nominate this patch for the 3.4 branch once it is
committed to ToT.

-Tom

> -- 
> Pekka
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits