r195323 - Add new attribute 'objc_suppress_protocol' to suppress protocol conformance for a class.

Aaron Ballman aaron at aaronballman.com
Thu Nov 21 08:04:48 PST 2013


On Thu, Nov 21, 2013 at 11:00 AM, Ted Kremenek <kremenek at apple.com> wrote:
> Thanks for the feedback!
>
>> On Nov 21, 2013, at 5:27 AM, Aaron Ballman <aaron at aaronballman.com> wrote:
>>
>> You should also add a test case for the number and type of args passed in.
>>
>
> We are deliberately not checking for the type of the arguments.  The
> protocol does not need to exist in the translation unit for this attribute
> to be applied.

Small misunderstanding -- I meant you should add test cases to ensure
proper diagnostics for things like an expr passed (instead of an
ident), or no args/two args passed instead of one.

~Aaron



More information about the cfe-commits mailing list