[PATCH] Adding support for NoDuplicate function attribute in CLang

Aaron Ballman aaron at aaronballman.com
Wed Nov 20 16:19:29 PST 2013


Patch LGTM modulo Richard's comments.

~Aaron

On Wed, Nov 20, 2013 at 7:15 PM, Marcello Maggioni
<marcello at codeplay.com> wrote:
> The last patch I posted should already address that.
> (clang_noduplicatev2.patch)
>
> Cheers,
> Marcello
>
>
> On 21/11/13 00:11, Aaron Ballman wrote:
>>
>> On Wed, Nov 20, 2013 at 7:01 PM, Richard Smith <richard at metafoo.co.uk>
>> wrote:
>>>
>>> If this is supported by LLVM for all platforms, I don't see a good reason
>>> to
>>> restrict it to just OpenCL. Any hardware might have a barrier
>>> instruction,
>>> and if it does, we'd want the noduplicate behavior there.
>>
>> That's fine by me; I would say it should go under the clang namespace
>> for the C++11 attribute then.
>>
>> ~Aaron
>
>



More information about the cfe-commits mailing list