r195256 - Added an option to allow short function bodies be placed on a single line.

Alexander Kornienko alexfh at google.com
Wed Nov 20 09:28:06 PST 2013


On Wed, Nov 20, 2013 at 6:12 PM, Daniel Jasper <djasper at google.com> wrote:

>
>> @@ -681,6 +681,7 @@ void UnwrappedLineParser::parseStructura
>>              Style.BreakBeforeBraces == FormatStyle::BS_Stroustrup ||
>>              Style.BreakBeforeBraces == FormatStyle::BS_Allman)
>>            addUnwrappedLine();
>>
>
> Does it still make sense to report the "{" as its own unwrapped line?
> Seems a bit convoluted to first report multiple lines and then merge them
> afterwards. I think this would make the merging code simpler.
>

It also seemed strange to me. Should we instead handle BreakBeforeBraces in
TokenAnnotator? This will require adding TokenType values for braces
starting namespaces, classes/structs and, probably, enums. I can play with
this a bit, it you think it makes sense.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131120/5484afd9/attachment.html>


More information about the cfe-commits mailing list