[patch] [libcxx] random.cpp not quite right for vc

Marshall Clow mclow.lists at gmail.com
Mon Nov 18 11:31:40 PST 2013


On Oct 9, 2013, at 8:41 PM, G M <gmisocpp at gmail.com> wrote:

> Hi Marshall
>  
> The random patch doesn't seem to have the fix I suggested in my code review here:
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090561.html
>  
> Yaron  mentioned he'd added it here:
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090566.html
>  
> I don't know if you applied an old revision of his patch or yaron forgot to add my suggestions after all but the attached patch makes it work for me with MSVC.

I'm really sorry that I missed this.
Is this misapplication still in the libc++ sources?

-- Marshall

Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>

A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).
        -- Yu Suzuki

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131118/f96c1eb4/attachment.html>


More information about the cfe-commits mailing list