[PATCH] Replaced bool parameters in SkipUntil function with single bit-based parameter.
Richard Smith
richard at metafoo.co.uk
Sun Nov 17 17:14:33 PST 2013
LGTM with some tiny changes.
================
Comment at: include/clang/Parse/Parser.h:743
@@ +742,3 @@
+ StopAtSemi = 1 << 0, /// \brief Stop skipping at semicolon
+ /// brief Stop skipping at specified token, but don't skip the token itself
+ StopBeforeMatch = 1 << 1,
----------------
Missing \ before brief. Also, please use the same style for all the comments here (put them all on the line before rather than having some before and some after the enumerator.
================
Comment at: include/clang/Parse/Parser.h:755
@@ -739,3 +754,3 @@
/// SkipUntil - Read tokens until we get to the specified token, then consume
- /// it (unless DontConsume is true). Because we cannot guarantee that the
+ /// it (unless no flag StopBeforeMatch). Because we cannot guarantee that the
/// token will ever occur, this skips to the next token, or to some likely
----------------
"(unless StopBeforeMatch is specified)".
http://llvm-reviews.chandlerc.com/D2108
More information about the cfe-commits
mailing list