[PATCH] Pass -I flags to the integrated assembler

[Tobias Grosser]

On 11/14/2013 10:52 PM, David Peixotto wrote:
>> I think passing -Wa,-I in all cases is non controversial. David, are you
>> >OK with implementing that first? If needed we can then discuss in which
>> >cases we should forward a plain -I.
> Yes, that works for me. I am ok for now as long as there is a way to get -I
> args to the integrated assembler.
>
> Please see the attached patch that passes -Wa,-I args to the integrated
> assembler.
>
>
>
> 0001-Pass-Wa-I-and-Xassembler-I-args-to-integrated-assemb.patch
>
>
>  From 9db8a3eb30a7e7252b175badef4d9fcfccd34980 Mon Sep 17 00:00:00 2001
> From: David Peixotto<dpeixott at codeaurora.org>
> Date: Thu, 14 Nov 2013 09:39:17 -0800
> Subject: [PATCH 1/2] Pass -Wa,-I and -Xassembler -I args to integrated
>   assembler
>
> This patch adds -I to the arguments that are passed to the
> integrated assembler from -Wa, and -Xassembler args.
> ---
>   lib/Driver/Tools.cpp        |   18 ++++++++++++++++++
>   test/Driver/integrated-as.s |   21 +++++++++++++++++++++
>   2 files changed, 39 insertions(+), 0 deletions(-)
>
> diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp
> index 03459f0..8aa98eb 100644
> --- a/lib/Driver/Tools.cpp
> +++ b/lib/Driver/Tools.cpp
> @@ -1707,6 +1707,13 @@ static void CollectArgsForIntegratedAssembler(Compilation &C,
>       if (UseRelaxAll(C, Args))
>         CmdArgs.push_back("-mrelax-all");
>
> +    // When passing -I arguments to the assembler we sometimes need to
> +    // uncontionally take the next argument.  For example, when parsing

           unconditionally

A minor typo above.


Cheers,
Tobias