[PATCH] Pass -I flags to the integrated assembler

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Nov 14 13:38:56 PST 2013


On 14 November 2013 13:26, Joerg Sonnenberger <joerg at britannica.bec.de> wrote:
> On Thu, Nov 14, 2013 at 09:58:50AM -0800, David Peixotto wrote:
>> With these patches the behavior for -I args will be:
>>
>> 1. Pass '-I', '-Wa,-I', and '-Xassembler -I' down to gcc when assembling
>> (current behavior)
>> 2. Pass '-I', '-Wa,-I', and '-Xassembler -I' down to integrated assember
>> when assembling (new behavior)
>> 3. Pass '-Wa,-I', and '-Xassembler -I' to the system assembler (current
>> behavior)
>
> I don't like this difference, especially (2) vs (3). The GCC toolchain
> is mostly just for broken platforms noone has written a proper toolchain
> for yet, so it isn't that relevant. For me, (3) is the desirable
> behavior and interpreting it for ias is the best approach.


The gcc logic is to pass -I down when it "knows" the assembler is the
gnu assembler.

I think passing -Wa,-I in all cases is non controversial. David, are
you OK with implementing that first? If needed we can then discuss in
which cases we should forward a plain -I.

Cheers,
Rafael



More information about the cfe-commits mailing list