[PATCH] Pass -I flags to the integrated assembler

David Peixotto dpeixott at codeaurora.org
Thu Nov 14 11:18:40 PST 2013


> On Thu, Nov 14, 2013 at 09:58:50AM -0800, David Peixotto wrote:
> > With these patches the behavior for -I args will be:
> >
> > 1. Pass '-I', '-Wa,-I', and '-Xassembler -I' down to gcc when
> > assembling (current behavior) 2. Pass '-I', '-Wa,-I', and '-Xassembler
> > -I' down to integrated assember when assembling (new behavior) 3. Pass
> > '-Wa,-I', and '-Xassembler -I' to the system assembler (current
> > behavior)
> 
> I don't like this difference, especially (2) vs (3). The GCC toolchain is
> mostly just for broken platforms noone has written a proper toolchain for
> yet, so it isn't that relevant. For me, (3) is the desirable behavior and
> interpreting it for ias is the best approach.

Ok, so if we just take the first patch then we would pass '-Wa,-I' and
'-Xassembler -I' flags to the integrated assembler, but not the plain '-I'
args. I think I am ok with that because it still gives me a way to pass '-I'
args to the integrated assembler.

The plan will be to just commit the first patch after it goes through review
and abandon the second patch. Any feedback on the patch itself?




More information about the cfe-commits mailing list