This is supposed to use the string constant sharing mechanism, right? Maybe a test could be added that checks that the constant data is shared for two same string constants? Otherwise, LGTM. http://llvm-reviews.chandlerc.com/D894