Move <dynarray> into the experimental namespace

Richard Smith richard at metafoo.co.uk
Wed Nov 13 14:00:58 PST 2013


You're missing the 'namespace experimental {' from the synopsis.

The alias templates in the tests seem like overkill. Could you use 'using
std::experimental::dynarray;' ?

Otherwise, LGTM.

On Wed, Nov 13, 2013 at 12:26 PM, Marshall Clow <mclow.lists at gmail.com>wrote:

> [ META: This is the second (of two) patches that I want to land that move
> stuff that didn't make the C++14 standard into "experimental". ]
>
>
> Along with C++14, the standard committee is working on several "Technical
> Specifications", designed to bring features that for one reason or another
> weren't able to be in C++14 to people before the next version of the
> standard (C++17??).  Those of you who remember TR1 (from about 2005) - this
> is a similar process under a new name.
>
> There are several being worked on:
>         * Library Fundamentals
>         * Arrays of Runtime Bound
>         * Networking
>         * Concepts
>         * Filesystem
>
> This patch takes the implementation of <dynarray> that I wrote and
> committed into libc++ (before the committee removed the feature from
> C++14), and moves it into the new "experimental" area, which is where these
> TSes will live until they are enshrined in a future version of the standard.
>
> That area can be described as:
>         namespace std::experimental (feel free to alias this to something
> shorter in your code)
>         files live in the "experimental/" directory.
>
> If you're already using the <dynarray> in libc++, you'll have to change
> your code to:
>         #include <experimental/dynarray>
> and use
>         std::experimental:: dynarray <T>
>
> It's a good-sized patch, but it's just renaming things; if I actually
> changed some code, then I did it wrong.
>
> I believe that I have addressed all of Richard's concerns with the
> <optional> patch here.
>         * Versioned inline namespace  "inline namespace
> __array_extensions_v1"
>         * Nothing in std::
>
> [ I will re-submit the optional patch soon. ]
>
> -- Marshall
>
> Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>
>
> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is
> promptly moderated down to (-1, Flamebait).
>         -- Yu Suzuki
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131113/89fd6220/attachment.html>


More information about the cfe-commits mailing list