r194330 - Correctly set the target in fuse_ld.c correctly...

[David Chisnall]

I have been unable to track down why the test is failing, but I suspect it is in GetProgramPath() as that is the only logic that would differ between platforms.  If so, reverting this is just hiding the bug.

Do we have tests that the linker is searched for in the correct path already?

David

On 9 Nov 2013, at 20:41, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> I reverted this (and dependencies) since the test was still failing on
> OS X and mingw.
> 
> On 9 November 2013 06:43, David Chisnall <csdavec at swan.ac.uk> wrote:
>> Author: theraven
>> Date: Sat Nov  9 08:43:08 2013
>> New Revision: 194330
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=194330&view=rev
>> Log:
>> Correctly set the target in fuse_ld.c correctly...
>> 
>> 
>> Modified:
>>    cfe/trunk/test/Driver/fuse_ld.c
>> 
>> Modified: cfe/trunk/test/Driver/fuse_ld.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/fuse_ld.c?rev=194330&r1=194329&r2=194330&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Driver/fuse_ld.c (original)
>> +++ cfe/trunk/test/Driver/fuse_ld.c Sat Nov  9 08:43:08 2013
>> @@ -1,17 +1,17 @@
>> -// RUN: %clang %s -target=x86_64-unknown-freebsd -### 2>&1 | FileCheck %s
>> +// RUN: %clang %s -target x86_64-unknown-freebsd -### 2>&1 | FileCheck %s
>> // CHECK: ld
>> // RUN: %clang -fuse-ld=bfd --sysroot=%S/Inputs/basic_freebsd_tree \
>> -// RUN:   -target=x86_64-unknown-freebsd \
>> +// RUN:   -target x86_64-unknown-freebsd \
>> // RUN:   -B%S/Inputs/basic_freebsd_tree %s  -### 2>&1 | \
>> // RUN:    FileCheck -check-prefix=CHECK-BFD %s
>> // CHECK-BFD: ld.bfd
>> // RUN: %clang -fuse-ld=gold --sysroot=%S/Inputs/basic_freebsd_tree \
>> -// RUN:   -target=x86_64-unknown-freebsd \
>> +// RUN:   -target x86_64-unknown-freebsd \
>> // RUN:   -B%S/Inputs/basic_freebsd_tree %s -### 2>&1 | \
>> // RUN:    FileCheck -check-prefix=CHECK-GOLD %s
>> // CHECK-GOLD: ld.gold
>> // RUN: %clang -fuse-ld=plib --sysroot=%S/Inputs/basic_freebsd_tree \
>> -// RUN:   -target=x86_64-unknown-freebsd \
>> +// RUN:   -target x86_64-unknown-freebsd \
>> // RUN:   -B%S/Inputs/basic_freebsd_tree %s -### 2>&1 | \
>> // RUN:    FileCheck -check-prefix=CHECK-PLIB %s
>> // CHECK-PLIB: error: invalid linker name
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits