[PATCH] Fix toolchain detection on SL6

Will Dietz wdietz2 at illinois.edu
Thu Nov 7 16:44:58 PST 2013


Looks like this is unnecessary and was actually only temporarily
broken by r193528, which was reverted quickly and fixed shortly
thereafter in r193554 and others.

AFAICT "--no-add-needed" is not used by default, so it seems the
default handling for an unknown target is appropriate.

Thanks for the feedback, and hooray my SL6 builds work again :).

~Will

On Mon, Oct 28, 2013 at 5:30 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> Since we don't seem to need to know the difference from
> ScientificLinux6 to ScientificLinux5, I would suggest starting with
> just ScientificLinux.
>
> Can you add a test? You should be able to create tree with a
> redhat-realease file and, for example, test that we pass
> --no-add-needed to the linker (assuming that is correct behavior for
> SL6).
>
> Thanks,
> Rafael




More information about the cfe-commits mailing list