[PATCH] Thread the info about vbptr sharing through ASTRecordLayout

Reid Kleckner rnk at google.com
Thu Nov 7 11:44:04 PST 2013


  Thanks, LGTM!


================
Comment at: include/clang/AST/RecordLayout.h:263
@@ -258,3 +262,3 @@
     assert(CXXInfo && "Record layout does not have C++ specific info!");
     return CXXInfo->HasOwnVBPtr;
   }
----------------
This can be hasVBPtr() && !BaseSharingVBPtr.

================
Comment at: include/clang/AST/RecordLayout.h:102-105
@@ -101,6 +101,6 @@
     
     /// HasOwnVBPtr - Does this class provide a virtual function table
     /// (vtable in Itanium, VBtbl in Microsoft) that is independent from
     /// its base classes?
     bool HasOwnVBPtr : 1;
     
----------------
This can become dead.  The comment is wrong anyway.


http://llvm-reviews.chandlerc.com/D2120



More information about the cfe-commits mailing list