r194095 - Produce direct calls instead of alias to linkonce_odr functions.

Timur Iskhodzhanov timurrrr at google.com
Thu Nov 7 02:00:30 PST 2013


2013/11/7 Timur Iskhodzhanov <timurrrr at google.com>:
> 2013/11/6 Rafael EspĂ­ndola <rafael.espindola at gmail.com>:
>> On 6 November 2013 09:32, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>>>
>>>>
>>>> Here we go:
>>>> -----
>>>> template<typename T> class A {
>>>> ~A() {}
>>>> };
>>>> template class A<char>;
>>>> -----
>>>>
>>>
>>>  I can reproduce it. Debugging.
>>
>> Fixed in r194158. None of the existing "-cxx-abi microsoft" tests was
>> using -mconstructor-aliases, so I added a new test. Should some of the
>> existing tests be using -mconstructor-aliases?

Hm, interesting - I think the assertion fired even without -cxx-abi
microsoft, right?

> Yeah, I think so, as it's used by default by the driver IIRC.
> Can you suggest a good criteria to add this flag?
> e.g. is it fine to just enable it for all/most of the tests?
>
>> Cheers,
>> Rafael




More information about the cfe-commits mailing list