r194165 - clang-cl: Add /FS as an ignored flag

[Hans Wennborg]

On Wed, Nov 6, 2013 at 2:18 PM, Alp Toker <alp at nuanti.com> wrote:
>
> On 06/11/2013 22:00, Hans Wennborg wrote:
>> On Wed, Nov 6, 2013 at 1:01 PM, Alp Toker <alp at nuanti.com> wrote:
>>> Author: alp
>>> Date: Wed Nov  6 15:01:23 2013
>>> New Revision: 194165
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=194165&view=rev
>>> Log:
>>> clang-cl: Add /FS as an ignored flag
>>>
>>> CMake-generated Makefiles include this cl flag which can be safely ignored
>>> until we get PDB server support.
>>>
>>> Modified:
>>>     cfe/trunk/include/clang/Driver/CLCompatOptions.td
>>>
>>> Modified: cfe/trunk/include/clang/Driver/CLCompatOptions.td
>>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CLCompatOptions.td?rev=194165&r1=194164&r2=194165&view=diff
>>> ==============================================================================
>>> --- cfe/trunk/include/clang/Driver/CLCompatOptions.td (original)
>>> +++ cfe/trunk/include/clang/Driver/CLCompatOptions.td Wed Nov  6 15:01:23 2013
>>> @@ -151,6 +151,7 @@ def _SLASH_TP : CLCompileFlag<"TP">, Hel
>>>
>>>  def _SLASH_analyze_ : CLIgnoredFlag<"analyze-">;
>>>  def _SLASH_errorReport : CLIgnoredJoined<"errorReport">;
>>> +def _SLASH_FS : CLIgnoredFlag<"FS">, HelpText<"Force synchronous PDB writes">;
>> Can you remove the HelpText for this option? We haven't been setting
>> help texts for ignored options because then the options show up in the
>> /? output which can seem confusing.
>
> I'd prefer to start documenting these flags, and HelpText is more
> natural than putting comments in the code.
>
> We can suppress them with HelpHidden in the tablegen class instead:
>
>  class CLIgnoredFlag<string name> : Option<["/", "-"], name, KIND_FLAG>,
> -  Group<cl_ignored_Group>, Flags<[CLOption, DriverOption]>;
> +  Group<cl_ignored_Group>, Flags<[CLOption, DriverOption, HelpHidden]>;
>
> OK with you?

Yes, that sounds good.

Thanks,
Hans