[PATCH] Implement aarch64 NEON copy_lane intrinsic with float type

Kevin Qin kevinqindev at gmail.com
Mon Nov 4 00:40:09 PST 2013


Hi Tim,

I added some CodeGen test and try to use clang-format to check code style.
I guess there will be less code format problem in future:)
Please review,thanks.


2013/11/1 Tim Northover <t.p.northover at gmail.com>

> Hi Kevin,
>
> The Clang patch looks good, and as far as I can see the LLVM one is OK
> except that it needs CodeGen tests.
>
> Oh, and the spacing on this line and the int version is wonky:
> +        EltVT = (EltSize == 64)? MVT::f64: MVT::f32;
>
> Cheers.
>
> Tim.
>



-- 
Best Regards,

Kevin Qin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131104/eb5f939e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: neon-copy-fix3.clang
Type: application/octet-stream
Size: 14108 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131104/eb5f939e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: neon-copy-fix3.llvm
Type: application/octet-stream
Size: 16232 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131104/eb5f939e/attachment-0001.obj>


More information about the cfe-commits mailing list