[Patch] Disable -Wtaulological-compare for substituted template types

David Blaikie dblaikie at gmail.com
Thu Oct 31 10:35:37 PDT 2013

Looks pretty reasonable - but are these two separate code changes, or do
they interrelate in some way? If they're separate changes that can have
separate test cases, it'd be nice to commit them each in their on commit
just for clarity.

Have you considered/plan to look at non-type template parameters?

template<int Num>
bool greater(unsigned Val) {
  return Val >= Num;

... greater<0>(42); ...

I'm not sure if this tickles the same kind of problem or not - but might be
worth checking.

On Wed, Oct 30, 2013 at 8:17 PM, Richard Trieu <rtrieu at google.com> wrote:

> This patch turns off the tautological compare warnings when one of the
> operands is a template parameter type.  There's not an easy way to correct
> the code or silence this warning so this way seemed to be the best
> solution.  Anyone have any thoughts on altering the behavior of this
> warning?
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131031/a1047c7a/attachment.html>

More information about the cfe-commits mailing list