[PATCH] Fix -mthumb resetting of target cpu

Bernard Ogden bernard.ogden at arm.com
Thu Oct 31 09:03:00 PDT 2013


  FIXMEs - yes, I'll file bugs, shoulda thought of that.

  As for pulling out the duplicate switches, yes that makes sense. ToolChain.h might be a good fit, but that would require putting one ARM-specific function in an otherwise generic interface. Tools.h has a similar problem - though it's namespaced, this would be a very different kind of function to be inserting up there (and creating an arm namespace in there will presumably have lots of knock-on consequences, and maybe play interestingly with the darwin one). I'll have to think a bit more about where this function could go.

  Are you referring to a different ordering of the strings in the two switches? If not then I've misunderstood you.

http://llvm-reviews.chandlerc.com/D2061



More information about the cfe-commits mailing list