[PATCH] Simplify handling of iboutletcollection and vec_type_hint attributes

Aaron Ballman aaron at aaronballman.com
Thu Oct 31 06:52:32 PDT 2013


Spare time happened last night; I've attached a patch which
generalizes this into something table-driven instead of relying on a
hard-coded list of attributes in ParseDecl.cpp.

~Aaron

On Wed, Oct 30, 2013 at 10:43 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Wed, Oct 30, 2013 at 10:00 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>> On Wed, Oct 30, 2013 at 6:42 PM, Aaron Ballman <aaron at aaronballman.com>
>> wrote:
>>>
>>> Instead of hard-coding the attributes which expect a type, is there a
>>> way we can gather that information off the tablegen?  They currently
>>> take a TypeArgument as their first argument, so it should be pretty
>>> simple to modify the attr emitter to provide a list of attributes
>>> which apply.  Then the parser doesn't have hard-coded knowledge about
>>> these one-offs.
>>
>>
>> Yes, we should, but I didn't want to put too much into a single patch.
>
> Makes sense; it's easy enough for me to do that work when I have some
> spare time.
>
> ~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TypeAttr.patch
Type: application/octet-stream
Size: 6188 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131031/c43f74d1/attachment.obj>


More information about the cfe-commits mailing list