r193722 - Fix Windows build by including CGFunctionInfo.h.

[Mark Lacey]

I’m trying to make a reduced test case now to answer that question.

Mark

On Oct 30, 2013, at 4:50 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> Interesting. Is this something clang should produce an error for too?
> 
> On 30 October 2013 19:40, Mark Lacey <mark.lacey at apple.com> wrote:
>> Author: rudkx
>> Date: Wed Oct 30 18:40:28 2013
>> New Revision: 193722
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=193722&view=rev
>> Log:
>> Fix Windows build by including CGFunctionInfo.h.
>> 
>> CodeGenTypes.h instantiates llvm::FoldingSet<> with CGFunctionInfo,
>> and VC++ doesn't like the static_cast from FoldingSetImpl::Node* to
>> CGFunctionInfo* since it hasn't seen the definition of CGFunctionInfo
>> and that it inherits from FoldingSetImpl::Node.
>> 
>> Modified:
>>    cfe/trunk/lib/CodeGen/CodeGenTypes.h
>> 
>> Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CodeGenTypes.h?rev=193722&r1=193721&r2=193722&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/CodeGen/CodeGenTypes.h (original)
>> +++ cfe/trunk/lib/CodeGen/CodeGenTypes.h Wed Oct 30 18:40:28 2013
>> @@ -16,6 +16,7 @@
>> 
>> #include "CGCall.h"
>> #include "clang/AST/GlobalDecl.h"
>> +#include "clang/CodeGen/CGFunctionInfo.h"
>> #include "llvm/ADT/DenseMap.h"
>> #include "llvm/IR/Module.h"
>> #include <vector>
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits