[patch] Slightly less hackish implementation of -Wwrite-strings

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Oct 29 07:48:24 PDT 2013


On 25 September 2013 17:44, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> With this patch -Wwrite-strings is still implemented with the terrible
> hack of passing -fconst-strings to -cc1, but at least the driver uses
> the regular warning checking code path.
> Since we don't support a warning that is DefaultIgnore in one language
> but not in another, this patch
> creates a dummy C only warning in the same group as the existing one
> to get the desired effect.
> Chandler, is the include of clang/Sema/SemaDiagnostic.h OK in here or
> some extra refactoring is needed?
> Cheers,
> Rafael

More information about the cfe-commits mailing list