r188906 - Centralize the handling of -target-feature.

[Lang Hames]

Hi Rafael,

I noticed that as a consequence of this patch, clang is issuing the
following warning when assembling for arm:

"'+soft-float-abi' is not a recognized feature for this target (ignoring
feature)"

You can reproduce this (at least on Darwin, and I expect on Linux too) by
creating an empty foo.s file and running:

clang -arch armv7 -c foo.s

It looks like the cause of the warning is that both Clang::ConstructJob and
ClangAs::ConstructJob are both calling getARMTargetFeatures (indirectly via
getTargetFeatures), and getARMTargetFeatures always adds the
abi-appropriate flag, even when the driver was being invoked as an
assembler.

I'm not very familiar with the driver code, so I didn't want to jump in and
undo any of the useful parts of your refactor to fix this.

Do you have any thoughts on the right way to omit this flag when assembling?

Cheers,
Lang.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131028/e1d9f387/attachment.html>