r193528 - Support cross linking to arm on ubuntu.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Oct 28 16:21:43 PDT 2013


On 28 October 2013 18:56, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Mon, Oct 28, 2013 at 11:52 AM, Rafael Espindola
> <rafael.espindola at gmail.com> wrote:
>>
>> -// CHECK-MULTI32-I386:
>> "-L[[gcc_install]]/../../../../i386-unknown-linux/lib/../lib32"
>> +// CHECK-MULTI32-I386:
>> "-L[[gcc_install]]/../../../../i386-unknown-linux/lib/../lib"
>>  // CHECK-MULTI32-I386:
>> "-L[[gcc_install]]/../../../../i386-unknown-linux/lib"
>>  // CHECK-MULTI32-I386: "-L[[sysroot]]/lib"
>>  // CHECK-MULTI32-I386: "-L[[sysroot]]/usr/lib"
>> @@ -89,7 +89,7 @@
>>  // CHECK-MULTI64-X86-64: "-m" "elf_x86_64"
>>  // CHECK-MULTI64-X86-64: "crti.o"
>> "[[gcc_install:.*/Inputs/multilib_64bit_linux_tree/usr/lib/gcc/x86_64-unknown-linux/4.6.0]]{{/|\\\\}}crtbegin.o"
>>  // CHECK-MULTI64-X86-64: "-L[[gcc_install]]"
>> -// CHECK-MULTI64-X86-64:
>> "-L[[gcc_install]]/../../../../x86_64-unknown-linux/lib/../lib64"
>> +// CHECK-MULTI64-X86-64:
>> "-L[[gcc_install]]/../../../../x86_64-unknown-linux/lib/../lib"
>
>
> Rafael, this change is completely wrong. The tests were added verifying this
> behavior because we actually need this exact behavior!! =[ This is blocking
> us from moving forward, please revert while we discuss?

Sure. Revered in 193554.

So, part of the problem is that it was not clear what the
x86_64-unknown-linux tree was. It was looking like a mix of different
systems, so it looked like correct change.

What is the characteristic of the tree that should make us conclude it
is biarch? The existence of the lib64 directory itself?

Cheers,
Rafael



More information about the cfe-commits mailing list