[PATCH] Allow string literals as module identifiers

Daniel Jasper djasper at google.com
Fri Oct 25 05:42:22 PDT 2013


Hi rsmith, doug.gregor, klimek,

In order to make the migration to modules easier, it seems to be helpful to allow a 1:1 mapping between target names of a current build system and the corresponding C++ modules. As  such targets commonly contain characters like "-". ":" and "/", allowing arbitrary quote-escaped strings seems to be a straightforward option.

Also improve the error message on missing use-declarations.

http://llvm-reviews.chandlerc.com/D2024

Files:
  docs/Modules.rst
  include/clang/Basic/DiagnosticLexKinds.td
  lib/Lex/ModuleMap.cpp
  lib/Lex/PPDirectives.cpp
  lib/Lex/Preprocessor.cpp
  test/Modules/Inputs/declare-use/h.h
  test/Modules/Inputs/string_names/a.h
  test/Modules/Inputs/string_names/b.h
  test/Modules/Inputs/string_names/c.h
  test/Modules/Inputs/string_names/module.map
  test/Modules/Inputs/string_names/sub.h
  test/Modules/declare-use1.cpp
  test/Modules/declare-use2.cpp
  test/Modules/string_names.cpp
  test/Modules/string_names.m
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2024.1.patch
Type: text/x-patch
Size: 7823 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131025/3f5c5bcf/attachment.bin>


More information about the cfe-commits mailing list