[PATCH] [libcxx] Use better prefix for macro indicating a shared DLL build

[Reid Kleckner]

Digging through old stuff...

Changing the macro identifier seems like obvious goodness, so long as we
can get it defined at the right time.

diff --git a/lib/CMakeLists.txt b/lib/CMakeLists.txt
index 9f28f68..a65f8ce 100644
--- a/lib/CMakeLists.txt
+++ b/lib/CMakeLists.txt
@@ -93,6 +93,7 @@ set_target_properties(cxx
     OUTPUT_NAME   "c++"
     VERSION       "1.0"
     SOVERSION     "1"
+    DEFINE_SYMBOL _LIBCPP_BUILD_SHARED

Should this be behind the LIBCXX_ENABLE_SHARED conditional?

   )

 install(TARGETS cxx
-- 
1.8.1.msysgit.1



On Thu, Oct 10, 2013 at 6:16 AM, Nico Rieck <nico.rieck at gmail.com> wrote:

> This changes the CMake-defined macro when building a Windows DLL to an
> implementation-reserved identifier.
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131024/15ba074b/attachment.html>