r193290 - Implements 64 bit microsoft record layout and adds lit tests to cover

Timur Iskhodzhanov timurrrr at google.com
Thu Oct 24 05:03:12 PDT 2013


That part was reverted already

2013/10/24 Sebastian Redl <sebastian.redl at getdesigned.at>:
> On 2013-10-24 01:53, Warren Hunt wrote:
>>
>> Author: whunt
>> Date: Wed Oct 23 18:53:07 2013
>> New Revision: 193290
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=193290&view=rev
>> Log:
>> Implements 64 bit microsoft record layout and adds lit tests to cover
>> it.  Also removes all of the microsoft C++ ABI related code from the
>> itanium layout builder.
>>
>> Differential Revision: http://llvm-reviews.chandlerc.com/D2003
>>
>>
>> Modified: cfe/trunk/docs/LanguageExtensions.rst
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/docs/LanguageExtensions.rst?rev=193290&r1=193289&r2=193290&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/docs/LanguageExtensions.rst (original)
>> +++ cfe/trunk/docs/LanguageExtensions.rst Wed Oct 23 18:53:07 2013
>> @@ -1181,23 +1181,19 @@ Objective-C requiring a call to ``super`
>>   --------------------------------------------------------
>>     Some Objective-C classes allow a subclass to override a particular
>> method in a
>> -parent class but expect that the overriding method also calls the
>> overridden
>> -method in the parent class. For these cases, we provide an attribute to
>> -designate that a method requires a "call to ``super``" in the overriding
>> -method in the subclass.
>> +parent class but expect that the override chains to calling the same
>> method in
>> +the parent class.  In such cases it is useful to be able to mark a method
>> as
>> +requiring this chaining behavior.  For these cases, we provide an
>> attribute to
>> +designate that a method requires a "call to ``super``" in the overriden
>> method
>> +in the subclass.
>>   -**Usage**: ``__attribute__((objc_requires_super))``.  This attribute
>> can only
>> -be placed at the end of a method declaration:
>> +**Usage**: ``__attribute__((objc_requires_super))``.  This attribute can
>> only be placed at the end of a method declaration:
>>     .. code-block:: objc
>>       - (void)foo __attribute__((objc_requires_super));
>>   -This attribute can only be applied the method declarations within a
>> class, and
>> -not a protocol.  Currently this attribute does not enforce any placement
>> of
>> -where the call occurs in the overriding method (such as in the case of
>> -``-dealloc`` where the call must appear at the end).  It checks only that
>> it
>> -exists.
>> +This attribute can only be applied the method declarations within a
>> class, and not a protocol.
>
>
> This looks like an unrelated change.
>
> Sebastian
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list