[PATCH] cleanup redudant includes in ASTTypeTraits.h
Manuel Klimek
klimek at google.com
Wed Oct 23 07:23:34 PDT 2013
Don't we need at least the definitions of AlignedCharArrayUnion and the
non-pointer types put into that:
llvm::AlignedCharArrayUnion<KindsByPointer, TemplateArgument,
NestedNameSpecifierLoc, QualType, TypeLoc>
Storage;
For the rest, I can see that we might want to make callers responsible for
having the type defined if they instantiate the template.
On Tue, Oct 22, 2013 at 5:44 PM, Daniel Marjamäki <
Daniel.Marjamaki at evidente.se> wrote:
> Hello!
>
> This is a small cleanup of some redundant #include's in ASTTypeTraits.h.
>
> No change in behaviour is intended. I just want to cleanup.
>
> The code compiles and all tests pass. However I believe there could be a
> danger with this change. There could be some "preprocessor magic". I assume
> that these headers were included because some types/variables/etc were
> needed.
>
> Best regards,
> Daniel Marjamäki
>
>
>
> ..................................................................................................................
>
> Daniel Marjamäki Senior Engineer
>
> Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden
>
>
>
> Mobile: +46 (0)709 12 42 62
>
> E-mail: Daniel.Marjamaki <Daniel.Marjamaki at evidente.se>
> @evidente.se <Daniel.Marjamaki at evidente.se>
>
>
>
> www.evidente.se
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131023/a7392264/attachment.html>
More information about the cfe-commits
mailing list