[PATCH] Remove LambdaExpr and use Flag for IsGenericLambda
Doug Gregor
dgregor at apple.com
Tue Oct 22 09:57:37 PDT 2013
Minor changes requested; feel free to commit when you make them.
================
Comment at: include/clang/AST/DeclCXX.h:542
@@ -537,1 +541,3 @@
+ /// has not been added to the lambda class, and lookup can fail.
+ bool IsGenericLambda : 1;
----------------
Please use "unsigned" rather than bool (it avoids some brokenness in Visual Studio, IIRC).
================
Comment at: include/clang/AST/DeclCXX.h:541
@@ +540,3 @@
+ /// isGenericLambda() can be called in a context where the CallOperator
+ /// has not been added to the lambda class, and lookup can fail.
+ bool IsGenericLambda : 1;
----------------
The extended part of this comment doesn't really add anything. The reader won't be surprised that we're distinguishing generic from non-generic lambdas. Please remove the comment.
================
Comment at: lib/AST/DeclCXX.cpp:964
@@ -946,1 +963,3 @@
+// certainly open to other strategies.
+
bool CXXRecordDecl::isGenericLambda() const {
----------------
Stale comment?
http://llvm-reviews.chandlerc.com/D1856
More information about the cfe-commits
mailing list