[PATCH] SanitizerArgs: add ability to filter/diagnose unsupported sanitizers.
Alexey Samsonov
samsonov at google.com
Tue Oct 22 01:57:34 PDT 2013
+Richard, who reviewed the original patch
I support this change.
================
Comment at: include/clang/Driver/SanitizerArgs.h:119
@@ +118,3 @@
+
+ static unsigned expandGroups(unsigned Kinds);
+
----------------
Can you add a comment for these functions?
================
Comment at: lib/Driver/SanitizerArgs.cpp:232
@@ +231,3 @@
+ TC.getTriple().getArch() == llvm::Triple::x86_64)) {
+ if (Kinds & Memory) {
+ Kinds &= ~Memory;
----------------
This part:
if (Kinds & Foo) {
Kinds &= ~Foo;
<...>
}
can be factored out into a separate function.
http://llvm-reviews.chandlerc.com/D1990
More information about the cfe-commits
mailing list