[PATCH] fix for CGDebugInfo.cpp filename append

[Hans Wennborg]

On Sat, Oct 19, 2013 at 1:07 AM, Yaron Keren <yaron.keren at gmail.com> wrote:
> Hi Hans,
>
> I just got commit access after approval rights.
>
> Is it OK to commit this patch ?

Looks good to me, but I agree with David's comment about doing
"MainFileName = MainFileDirSS.str()" - it's easier on the eyes.

Thanks,
Hans

> 2013/10/17 Hans Wennborg <hans at chromium.org>
>>
>> On Thu, Oct 17, 2013 at 8:09 AM, Yaron Keren <yaron.keren at gmail.com>
>> wrote:
>> > Hi,
>> >
>> > Filename appending in CGDebugInfo.cpp was implemented as simple string
>> > concatenation, resulting in duplicate file debug information on Windows
>> > due
>> > to wrong path separator.
>> >
>> > The patch uses  llvm::sys::path::append to properly append the filename
>> > on
>> > all OS.
>> >
>> > Is there a way to use path::append without the SmallString temporary?
>> >
>> > Yaron
>>
>> The patch looks reasonable to me, but I wish there were a test we
>> could update for this.
>>
>> Maybe the debug info folks know if there is a test that picks up the
>> -main-file-name?
>>
>>  - Hans
>
>