[PATCH][StaticAnalyzer] Cleanup redundant includes

[Daniel Marjamäki]

Hello!

> You only need to forward declare CallExpr in PathDiagnostic.h. LGTM with that.

True!! I missed that. Thanks.

> Do you have commit access or do you need someone to commit it for you?

I need someone to commit it for me.

Best regards,
Daniel Marjamäki

..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden

Mobile:                 +46 (0)709 12 42 62
E-mail:                 Daniel.Marjamaki at evidente.se

www.evidente.se

________________________________________
Från: Rafael Espíndola [rafael.espindola at gmail.com]
Skickat: den 21 oktober 2013 15:51
Till: Daniel Marjamäki
Cc: cfe-commits at cs.uiuc.edu
Ämne: Re: [PATCH][StaticAnalyzer] Cleanup redundant includes

You only need to forward declare CallExpr in PathDiagnostic.h. LGTM with that.

Do you have commit access or do you need someone to commit it for you?

On 20 October 2013 10:44, Daniel Marjamäki <Daniel.Marjamaki at evidente.se> wrote:
> Hello!
>
> This is a small cleanup of some redundant #include's.
>
> No change in behaviour is intended. I just want to cleanup.
>
> The code compiles and all tests pass. However I believe there is a danger
> with this change. There could be some "preprocessor magic":
>  * Some symbol might be redefined in a header I removed (there are plenty of
> #undef).
>  * A enum might be generated differently (such as the "AtomicOp" in
> "Expr.h").
>
> I assume that these headers were included because some types/variables/etc
> were needed.
>
> Please consider if there is any dangerous changes before applying this.
>
> I moved the include "clang/AST/Expr.h" from AnalysisContext.h to
> PathDiagnostic.h since it was used in PathDiagnostic.h
>
> Best regards,
> Daniel Marjamäki
>
> ..................................................................................................................
>
> Daniel Marjamäki Senior Engineer
>
> Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden
>
>
>
> Mobile:                 +46 (0)709 12 42 62
>
> E-mail:                 Daniel.Marjamaki at evidente.se
>
>
>
> www.evidente.se
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: includes2.diff
Type: text/x-patch
Size: 1792 bytes
Desc: includes2.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131021/0ebb8a8a/attachment.bin>