[PATCH][StaticAnalyzer] Cleanup redundant includes
Daniel Marjamäki
Daniel.Marjamaki at evidente.se
Sun Oct 20 07:44:19 PDT 2013
Hello!
This is a small cleanup of some redundant #include's.
No change in behaviour is intended. I just want to cleanup.
The code compiles and all tests pass. However I believe there is a danger with this change. There could be some "preprocessor magic":
* Some symbol might be redefined in a header I removed (there are plenty of #undef).
* A enum might be generated differently (such as the "AtomicOp" in "Expr.h").
I assume that these headers were included because some types/variables/etc were needed.
Please consider if there is any dangerous changes before applying this.
I moved the include "clang/AST/Expr.h" from AnalysisContext.h to PathDiagnostic.h since it was used in PathDiagnostic.h
Best regards,
Daniel Marjamäki
..................................................................................................................
Daniel Marjamäki Senior Engineer
Evidente ES East AB Warfvinges väg 34 SE-112 51 Stockholm Sweden
Mobile: +46 (0)709 12 42 62
E-mail: Daniel.Marjamaki<mailto:Daniel.Marjamaki at evidente.se>@evidente.se<mailto:Daniel.Marjamaki at evidente.se>
www.evidente.se
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131020/3b8679f0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: includes.diff
Type: text/x-patch
Size: 1921 bytes
Desc: includes.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131020/3b8679f0/attachment.bin>
More information about the cfe-commits
mailing list