r192848 - Remove an old, seemingly out of date, comment.
Eric Christopher
echristo at gmail.com
Thu Oct 17 13:39:36 PDT 2013
Heh. Nice. That said I think the test has been updated a lot so we'd
need to update it as well.
-eric
On Thu, Oct 17, 2013 at 8:07 AM, Alp Toker <alp at nuanti.com> wrote:
> For the record, looks like the tests were added in r140673 to
> consolidate predefined macros but the script that generated them was
> never checked in.
>
> Perhaps Chandler could share his generate_arch_predefine_tests.sh --
> seems a worthy effort someone could pick up.
>
> ChangeLog from r140673:
>
> Author: Chandler Carruth <chandlerc at gmail.com>
> Date: Wed Sep 28 02:59:25 2011 +0000
>
> Begin fixing Clang's predefined macros for various architectures. This
> is *very* much a WIP that I'll be refining over the next several
> commits, but I need to get this checkpoint in place for sanity.
>
> This also adds a much more comprehensive test for architecture macros,
> which is roughly generated by inspecting the behavior of a trunk build
> of GCC. It still requires some massaging, but eventually I'll even check
> in the script that generates these so that others can use it to append
> more tests for more architectures, etc.
>
> Next up is a bunch of simplification of the Targets.cpp code, followed
> by a lot more test cases once we can reject invalid architectures.
>
>
>
> On 16/10/2013 22:19, Eric Christopher wrote:
>> Author: echristo
>> Date: Wed Oct 16 16:19:23 2013
>> New Revision: 192848
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=192848&view=rev
>> Log:
>> Remove an old, seemingly out of date, comment.
>>
>> The referenced script no longer seems to exist.
>>
>> Modified:
>> cfe/trunk/test/Preprocessor/predefined-arch-macros.c
>>
>> Modified: cfe/trunk/test/Preprocessor/predefined-arch-macros.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Preprocessor/predefined-arch-macros.c?rev=192848&r1=192847&r2=192848&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/Preprocessor/predefined-arch-macros.c (original)
>> +++ cfe/trunk/test/Preprocessor/predefined-arch-macros.c Wed Oct 16 16:19:23 2013
>> @@ -1,6 +1,3 @@
>> -// These tests are generated by running utils/generate_arch_predefine_tests.sh
>> -// to observe GCC's behavior (or some other system compiler's behavior).
>> -//
>> // Begin X86/GCC/Linux tests ----------------
>> //
>> // RUN: %clang -march=i386 -m32 -E -dM %s -o - 2>&1 \
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
> --
> http://www.nuanti.com
> the browser experts
>
More information about the cfe-commits
mailing list