XCore target, getPreferredTypeAlign() *MUST* return preferred alignment.

Robert Lytton robert at xmos.com
Wed Oct 16 09:03:01 PDT 2013


Hi

I've moved the _Static_assert tests from test/Driver/xcore-opts.c into test/CodeGen/xcore-abi.c.
Is the patch good to go?

Robert

________________________________
From: cfe-commits-bounces at cs.uiuc.edu [cfe-commits-bounces at cs.uiuc.edu] on behalf of Robert Lytton [robert at xmos.com]
Sent: 14 October 2013 13:33
To: cfe-commits at cs.uiuc.edu
Subject: XCore target, getPreferredTypeAlign() *MUST* return preferred alignment.

Hi

Here is a suggest patch to support the XCore target.

This is required as the the xcore llvm backend does not handle 8 byte alignment viz:
        %BadAlignment = alloca i64, align 8

(llvm will reject the above as an error)


The patch prevents the default behavior running:
    /// getPreferredTypeAlign - Return the "preferred" alignment of the specified
    /// type for the current target in bits.  This can be different than the ABI
    /// alignment in cases where it is beneficial for performance to overalign
    /// a data type.


Robert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131016/3d1b14dd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PatchPrefAlign
Type: application/octet-stream
Size: 2942 bytes
Desc: PatchPrefAlign
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131016/3d1b14dd/attachment.obj>


More information about the cfe-commits mailing list