[Patch] Mangle C __stdcall and __fastcall in clang
Rafael EspĂndola
rafael.espindola at gmail.com
Tue Oct 15 12:58:58 PDT 2013
> shouldMangleDeclNameImpl can be shouldMangleCXXName, following the same
> logic as mangleName.
Done.
> This AttributedType handling isn't necessary, use T->castAs<FunctionType>()
> instead of cast<>() to look through the type sugar.
This is awesome. Done.
> + return mangleCXXName(D, Out);
>
> We shouldn't apply the stdcall or fastcall manglings to C++ symbols. You
> should check if we should mangle this as a C++ name first, and after that
> see if we need to apply C manglings.
Thanks. I noticed that we were not quoting the mingw case. I have
fixed the logic and added a c++ testcase.
Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: application/octet-stream
Size: 14239 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131015/d93e20c4/attachment.obj>
More information about the cfe-commits
mailing list