r192521 - Add missing flags -fexpensive-optimizations and -minline-all-stringops as noops.

[Nick Lewycky]

On 12 October 2013 05:28, Joerg Sonnenberger <joerg at britannica.bec.de>wrote:

> On Sat, Oct 12, 2013 at 04:24:32AM -0000, Nick Lewycky wrote:
> > Author: nicholas
> > Date: Fri Oct 11 23:24:31 2013
> > New Revision: 192521
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=192521&view=rev
> > Log:
> > Add missing flags -fexpensive-optimizations and -minline-all-stringops
> as noops.
>
> Do we really want to emulate them? I haven't seen either as problem in
> pkgsrc.


Yes, I have actually run into these.

-fexpensive-optimizations: http://www.ks.uiuc.edu/Research/phi/
-minline-all-stringops: povray

At the latter, I would consider possibly harmful since Clang
> will create calls to memset() etc in some situations.
>

As a practical matter, I'm adding these so that I can continue to build
software that used to build. They're marked clang_ignored_[fm]_Group so
that we can find which flags aren't implemented.

I'm not sure what you're saying -- are you arguing that implementing
-minline-all-stringops is dangerous, or that silently ignoring
-minline-all-stringops is dangerous?

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131014/d80eb73c/attachment.html>