[libcxx] r192609 - r192075 broke the buildbot at

Howard Hinnant hhinnant at apple.com
Mon Oct 14 11:02:02 PDT 2013


Author: hhinnant
Date: Mon Oct 14 13:02:02 2013
New Revision: 192609

URL: http://llvm.org/viewvc/llvm-project?rev=192609&view=rev
Log:
r192075 broke the buildbot at

    http://lab.llvm.org:8013/builders/libcxx_clang-x86_64-darwin11-RA

lit.py: <string>:230: note: inferred use_system_lib as: False
lit.py: <string>:247: fatal: C++ ABI setting None unsupported for tests

cxx_abi is geting set to None, and the lit script errors out shortly after
that.  This patch changes the default of cxx_abi from None to 'libcxxabi'.
This is likely not the right way to fix this problem.  However it gets the
buildbot running again.  Improvements to this fix are welcome.

Modified:
    libcxx/trunk/test/lit.cfg

Modified: libcxx/trunk/test/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/lit.cfg?rev=192609&r1=192608&r2=192609&view=diff
==============================================================================
--- libcxx/trunk/test/lit.cfg (original)
+++ libcxx/trunk/test/lit.cfg Mon Oct 14 13:02:02 2013
@@ -234,7 +234,7 @@ link_flags_str = lit_config.params.get('
 if link_flags_str is None:
     link_flags_str = getattr(config, 'link_flags', None)
     if link_flags_str is None:
-      cxx_abi = getattr(config, 'cxx_abi', None)
+      cxx_abi = getattr(config, 'cxx_abi', 'libcxxabi')
       if cxx_abi == 'libstdc++':
         link_flags += ['-lstdc++']
       elif cxx_abi == 'libsupc++':





More information about the cfe-commits mailing list