[PATCH] [libcxx] Windows port of thread/mutex/chrono

[G M]

Hi Nico

I'm just looking at your chrono / thread / mutex stuff. Here:

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20131007/090709.html

First, sorry I only just noticed it! I'm pretty happy to see something like
this land!

The chrono patch.

Short version: LGTM.
Long: There's possibly more to this than you think for it to be "perfect"
but I don't know if we need perfect yet / at all.
I'll send you my own research notes on it and you can see what I mean. Then
you might (or might not) want to add more to this chrono patch, but the
patch as it stands LGTM. Howard, obviously means you can also forget my own
"not implemented" patch.

pthreads.

I've been playing with pthreads myself, I ported a "third party" library
myself to test with because I hadn't noticed your patch until now.
I have it compiling on my machine with libcxx in but haven't run the code
yet. Initially when I saw your patch I thought I'd wasted my time (not that
it took long) but actually I think it's been very useful so I can comment
better on your patch when I've had a bit more time to look at it.

I think a lot of the changes you made are complimentary to the changes I
made i.e. they would be exactly the same or help my port.
I'll apply your patch this weekend and report back. But your patch LGTM. I
can submit any revisions I think might be useful later.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131012/6e5675af/attachment.html>