[PATCH] Added callback support for OpenCL extension pragmas.

[Mikael Lepistö]

Hi, thanks for the comments!

I finally got time to update the patch on top of latest llvm-trunk revision
192297 and I removed the brackets as suggested.

Thanks, Mikael




On Fri, Sep 27, 2013 at 5:17 PM, Tom Stellard <tom at stellard.net> wrote:

> Hi Mikael,
>
> Sorry this patch fell through the cracks.  You should take a look at
> some of the previous OpenCL patches that were submitted and cc the
> people who reviewed those patches and also the code owner listed in
> clang/CODE_OWNERS.txt.
>
> The only issue I see with the patch is the brackets around the if
> statement here:
>
> +
> +  if (PP.getPPCallbacks()) {
> +    PP.getPPCallbacks()->PragmaOpenCLExtension(NameLoc, ename,
> +                                               StateLoc, state);
> +  }
>  }
>
> -Tom
>
> On Fri, Sep 27, 2013 at 11:13:23AM +0300, Mikael Lepistö wrote:
> > And here is also the patch file reattached from the original posting.
> >
> > - Mikael
> >
> >
> > On Fri, Sep 27, 2013 at 10:35 AM, Mikael Lepistö
> > <mikael.lepisto at vincit.fi>wrote:
> >
> > > Hi, I submitted this patch ~20 days ago. Could this get some
> > > comments/review if the solution is acceptable or if there is some other
> > > preferred way to implement it?
> > >
> > > Thanks, Mikael
> > >
> > >
> > > On Mon, Sep 16, 2013 at 8:37 AM, Mikael Lepistö <
> mikael.lepisto at vincit.fi>wrote:
> > >
> > >> Hi, ping
> > >>
> > >> I sent this simple patch some time ago to list, but it got no
> responses.
> > >> Is there any estimates, when this might be reviewed or added to main
> repo?
> > >>
> > >> Thanks, Mikael Lepistö
> > >>
> > >>
> > >> I also added missing [PATCH] tag to subject (I forgot to to put it to
> > >> original mail).
> > >>
> > >> On Sat, Sep 7, 2013 at 12:49 PM, Mikael Lepistö <
> mikael.lepisto at vincit.fi
> > >> > wrote:
> > >>
> > >>> Hi,
> > >>>
> > >>> We needed in our project (
> > >>> https://github.com/KhronosGroup/webcl-validator) to be able to
> define
> > >>> callbacks for handling OpenCL extension pragmas to catch easily which
> > >>> OpenCL extensions are enabled/disabled.
> > >>>
> > >>> I attached the patch file and test case for the functionality. Rami
> > >>> Ylimäki is actually author of the implementation I just wrote the
> test case
> > >>> and cleaned up the patch for upstreaming.
> > >>>
> > >>>  I had to add clangParse and clangSema libraries to PPCallbacksTest
> > >>> compilation, because enabling OpenCL support for preprocessor
> required
> > >>> Parser instance. Parser instance actually reads LangOptions from
> > >>> preprocessor and registers correct pragma handlers to preprocessor.
> > >>>
> > >>> Any comments, improvements?
> > >>>
> > >>> Cheers, Mikael Lepistö
> > >>>
> > >>>
> > >>>
> > >>
> > >
>
>
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131009/9fe1f78f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang_opencl_extension_pragma_callbacks_r192297.diff
Type: application/octet-stream
Size: 6781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131009/9fe1f78f/attachment.obj>