[PATCH] libcxx random_device for Win32 review

[G M]

Hi Yaron

Your random_device patch looks good. I'd consider making a few more
changes though:

1. I'd #if ! defined(_WIN32) the file handle f in the <random> header
as the Win32 version's wont use it AFAIKT.

2. Accordingly, I'd change random.cpp to remove the includes
relating to files for win32 to emphasis that further. i.e.:

#if ! defined(_WIN32)

#include <fcntl.h>

#include <unistd.h>

#endif

I did wonder if it was worth blending the implementations a bit more to
avoid replicating the function specifications etc. but on balance I'm not
suggesting that but others might have an opinion.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131009/7452cacc/attachment.html>