[PATCH] Abstract out parts of thunk emission code, add support for simple thunks for -cxx-abi microsoft

Reid Kleckner rnk at google.com
Tue Oct 8 09:50:35 PDT 2013



================
Comment at: include/clang/Basic/ABI.h:139
@@ -120,1 +138,3 @@
+
+    return LHS.Method < RHS.Method;
   }
----------------
This is comparing the pointers which are ordered non-deterministically across executions.  The compiler's output should be deterministic, even for dumping routines, because we run FileCheck tests against it.

================
Comment at: include/clang/Basic/ABI.h:119
@@ +118,3 @@
+  /// Otherwise, null.
+  const CXXMethodDecl *Method;
+
----------------
Which method is this?  The method being overridden or the overriding method?


http://llvm-reviews.chandlerc.com/D1787



More information about the cfe-commits mailing list