[PATCH] Make InstantiatingTemplate depth checks clearer

Richard Smith richard at metafoo.co.uk
Mon Oct 7 13:21:45 PDT 2013


On Sun, Oct 6, 2013 at 8:01 AM, Alp Toker <alp at nuanti.com> wrote:

> This one was caught by the RAII class style checker I mentioned on
> llvm-commits to improve code readability:
>
>     The bool conversion operator on InstantiatingTemplate never added
> value and
>     only served to obfuscate the template instantiation routines.
>
>     This patch replaces the conversion and its callers with an explicit
> isInvalid()
>     function to make it clear what's going on at a glance.
>
> OK to commit?


Yes, LGTM
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20131007/41da4c42/attachment.html>


More information about the cfe-commits mailing list